contrib/gofiber/fiber.v2: use UserContext in Middleware for span creation #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The Middleware was incorrectly using `c.Context()` instead of `c.UserContext()` to start spans. This could break the propagation of the context defined by other middlewares earlier in the chain. This change ensures that `tracer.StartSpanFromContext` uses the correct context provided by Fiber, preserving context propagation and ensuring proper tracing behavior. Fixes DataDog#2199
darccio
approved these changes
Dec 18, 2024
rarguelloF
requested changes
Jan 13, 2025
… creation The Middleware was incorrectly using `c.Context()` instead of `c.UserContext()` to start spans. This could break the propagation of the context defined by other middlewares earlier in the chain. This change ensures that `tracer.StartSpanFromContext` uses the correct context provided by Fiber, preserving context propagation and ensuring proper tracing behavior. Fixes DataDog#2199
rarguelloF
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Middleware was incorrectly using
c.Context()instead ofc.UserContext()to start spans. This could break the propagation of the context defined by other middlewares earlier in the chain.Motivation
This change ensures that
tracer.StartSpanFromContextuses the correct context provided by Fiber, preserving context propagation and ensuring proper tracing behavior.Fixes #2199
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.